Skip to content

Conversation

guibescos
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
example-oracle-amm ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 2:14pm
xc-admin-frontend ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 2:14pm

export const getGuardianSetPda = (
guardianSetIndex: number,
wormholeProgramId: PublicKey
) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added programId here in case we're not using the default address

@guibescos guibescos changed the title Solana/js sdk docs: code docs Feb 29, 2024
@guibescos guibescos changed the title docs: code docs docs: code docs for solana sdk Feb 29, 2024
*
* TX 2 : `writeEncodedVaa_2` + `verifyEncodedVaaV1`
*/
export async function buildWriteEncodedVaaWithSplitInstructions(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed for consistency

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. I left you some minor comments.

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@guibescos guibescos merged commit 16cc46e into main Mar 13, 2024
@guibescos guibescos deleted the solana/js-sdk branch March 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants